Fix/2148#332
Merged
Merged
Conversation
The pre-commit hook runs `prettier --write .` across the whole repo and `git add -u`, so pre-existing formatting drift on main (CHANGELOG bullet style, a missing trailing newline in an e2e spec) would otherwise be swept into an unrelated fix commit. Isolate it here so the fix and test commits stay focused. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
In embed mode the current username arrives as an empty string before hydration, and the proactive-greeting EOS handler fired the lazy guided-prompts trigger with it verbatim. That produced a malformed URL with an empty path segment (/users//sessions/) and a 404. Fall back to 'anonymous' when username is falsy, matching the other guided-prompts call sites, so the path segment is always valid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Assert the proactive-greeting EOS handler dispatches guided-prompts with userId 'anonymous' when the username is an empty string (embed mode), and passes a real username through unchanged. Guards against regressing the malformed /users//sessions/ URL. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Claude finished @conradmugabe's task —— View job E2E Coverage Review
SummaryThis PR only modifies hook files (no new |
mamigot
approved these changes
Jul 13, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — No Issues
No new app routes were introduced. All existing coverage is intact.
Member
|
Claude finished @conradmugabe's task —— View job E2E Coverage Review
SummaryThis PR only modifies hook files (no new |
mamigot
approved these changes
Jul 22, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — No Issues
No new app routes were introduced. All existing coverage is intact.
michael-on-code
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Changes